On Jul 7, 2008, at 17:15, Karl Fogel wrote:
> "Ben Collins-Sussman" <sussman_at_red-bean.com> writes:
>> On Sun, Jul 6, 2008 at 5:23 AM, Barry Scott <barry_at_barrys-
>> emacs.org> wrote:
>>> Using the svn_client API is it possible for a client to write
>>> none-UTF-8 log messages?
>>> Clearly if this happened it would be a bug in the client given the
>>> above statement.
>>
>> I don't recall the details, but it's actually the *programmers'*
>> burden to convert paths and log messages from native locale to UTF8
>> (and back again). If you read the svn APIs, you'll notice that every
>> path and log message passed into APIs (or passed around between APIs)
>> are presumed to *already* be UTF8. So if you're writing your own
>> client, it's your job to convert user input to UTF8 before passing to
>> svn_client_*(). Look at the commandline client to see how it's doing
>> that; I believe there a number of convenience routines in
>> libsvn_subr
>> to help with conversion.
>
> I think Barry's asking if the client and/or server do any validation.
> That is, if the programmer supplies a non-UTF8 log message, our client
> libraries should reject it; and if such a log message were to reach
> the
> repository (perhaps because someone wrote their own client software
> from
> scratch), the repository should reject it too.
>
> I don't know whether we do such validation or not, but agree we
> should.
>
> Barry, got time to test/trace it?
>
Karl's correct, I'm not asking for programming help, I'm trying to
understand
a user reported problem using pysvn. If the SVN API does not check that
the strings are UTF-8 then I can close the bug as not pysvn's problem.
Another client must have messed up the users repos.
The user has not given me their repos to test against.
Barry
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-07 23:27:03 CEST