Re: [PATCH] Support Berkeley DB 4.7

Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-07-02 20:33:50 C. Michael Pilato napisał(a):
>> Arfrever Frehtes Taifersar Arahesis wrote:
>>> [[[
>>> Support Berkeley DB 4.7.
>>>
>>> * subversion/libsvn_fs_base/fs.c
>>> (check_env_flags, get_db_pagesize, base_hotcopy):
>>> Use '#if DB_VERSION_MINOR >= 2' instead of '#ifdef DB_LOG_AUTOREMOVE'
>>> to check for Berkeley DB >= 4.2.
>>> (check_env_flags):
>>> Call DB_ENV->log_get_config() instead of DB_ENV->get_flags() for
>>> Berkeley DB >= 4.7.
>>> (base_hotcopy):
>>> Call check_env_flags() with DB_LOG_AUTO_REMOVE instead of DB_LOG_AUTOREMOVE
>>> for Berkeley DB >= 4.7.
>>>
>>> * build/generator/gen_win.py
>>> (GeneratorBase._find_bdb): Allow Berkeley DB 4.7.
>>> ]]]

Patch looks good. I'd still prefer to see all the #ifdef-y stuff moved to
bdb_compat.[ch], but I'll get over it.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand