Senthil Kumaran S wrote:
> You must remove reference to svn_cl__print_xml_prop from
> subversion/svn/cl.h
> (you can add the attached patch to your, existing patch and tweak the
> log message accordingly).
Thanks, Senthil. Done.
Karl Fogel wrote:
> Julian Foad <julianfoad_at_btopenworld.com> writes:
>
> > OK, here's a go at factoring out this print-a-property-as-XML function
> > "svn_cl__print_xml_prop()" function so that it can be shared with
> > "svnlook", by moving it into libsvn_client and calling it
> > "svn_client__print_xml_prop()".
> >
> > I didn't put it in "cmdline.c" because it's not actually doing
> > command-line output, just forming XML in a string buffer, and generating
> > XML-formatting output is not specific to command-line clients.
> >
> > So it's in a new file "subversion/libsvn_client/xml.c".
>
> Another possibility is to put it in libsvn_subr/xml.c, in the
> "svn_xml__" namespace in include/private/svn_xml_private.h (which would
> have to be created).
>
> -Karl
Thanks for the suggestion, Karl. I had considered this but prefer not to
mix up functions for handling "pure" XML with functions that know
something about Subversion-specific data, so I have left this in
libsvn_client.
Committed revision 32015.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-07 14:03:52 CEST