On Sat, Jun 21, 2008 at 9:07 AM, David James <james_at_cs.toronto.edu> wrote:
> On Tue, Jun 17, 2008 at 7:41 PM, Eric Gillespie <epg_at_pretzelnet.org> wrote:
>> I started testing csvn again, and found a problem.
>> csvn/core/__init__.py calls svn_cmdline_init! That function does
>> all kinds of things that are inappropriate for many programs
>> (e.g. mucking with locale, mucking with stdout, printing to
>> stderr, terminating the process). And it certainly shouldn't be
>> called on import.
>>
>>
>> Maybe we can add a csvn.SimpleInit function for high-level
>> consumers who don't want to think about; anyone else will have to
>> read the documentation to see what all they may have to
>> initialize, and how those things may fail.
>
> Great points. This will break compatibility with all scripts, but,
> fortunately, this is OK because the ctypes python bindings haven't
> been released yet. If everyone is OK with this idea I'll go ahead and
> implement this.
Hi Eric,
Per your suggestion, I got rid of the call to svn_cmdline_init in
r32005. I updated the example scripts in a few followup commits and
this should be complete as of r32009.
As of now, ctypes python bindings test suite should pass successfully
on at least the following platforms:
- Windows
- Linux 64-bit
- Linux 32-bit
- Mac OS X (32-bit)
To run the ctypes python bindings on Windows I generate the wrappers
for the bindings on Linux and then copy the python files to Windows.
This seems to work just fine.
On Windows and 64-bit Linux I went a bit further and ran the complete
svnmucc test suite on my example mucc.py. mucc.py passes all tests
now. (Note that I had to make a few tweaks to the svnmucc test suite
to get it to run on Windows, and to run outside of an svn build dir.)
It might make sense to integrate the mucc tests into the ctypes python
bindings test suite as they seem to be good at catching bugs.
I think we are getting closer to being able to merge the
ctypes-python-bindings to trunk alongside the SWIG bindings.
Cheers,
David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-05 19:00:58 CEST