Re: [PATCH] Fix issue #2809

Hi Julian,

Julian Foad wrote:
> I tweaked just a little bit more. I noticed that your "print_xml_prop()"
> function is an exact copy of "svn_cl__print_xml_prop()". I added a
> comment above it, saying so, so that when someone is modifying it later
> they will realise that they may have to make their modifications in two
> places to maintain consistency. When you copy and paste a significant
> amount of code, it's good to point this out, so that the reviewer knows
> it was a deliberate decision, because we normally try to avoid doing
> this.

I made a note of this in the log message. In future will do it inside the code
as you have pointed out, since that seems right for maintaining it.

> I've committed this in 31978 and marked the issue as fixed.

Thank you for the commit.

-- 
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org