Re: svn commit: r31978 - trunk/subversion/svnlook

julianfoad_at_tigris.org writes:
> --- trunk/subversion/svnlook/main.c (r31977)
> +++ trunk/subversion/svnlook/main.c (r31978)
> @@ -1533,6 +1540,48 @@ do_pget(svnlook_ctxt_t *c,
> }
>
>
> +/* A copy of svn_cl__print_xml_prop(). */
> +static void
> +print_xml_prop(svn_stringbuf_t **outstr,
> + const char* propname,
> + svn_string_t *propval,
> + apr_pool_t *pool)

My alarm bells went off when I saw that, naturally :-).

Why not just use svn_cl__print_xml_prop(), then?

> @@ -1542,6 +1591,7 @@ static svn_error_t *
> do_plist(svnlook_ctxt_t *c,
> const char *path,
> svn_boolean_t verbose,
> + svn_boolean_t xml,
> apr_pool_t *pool)

The do_plist() function has a doc string; it should be updated for the
new 'xml' parameter.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-02 23:15:01 CEST