[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

blame can access NULL-pointer

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 02 Jul 2008 18:19:45 +0200

Hi,

In file subversion\libsvn_client\blame.c, line 684 there is an assert:

   /* The callback has to have been called at least once. */
   assert(frb.last_filename != NULL);

I just got a crash report for TSVN where this assert is being hit: the
user passed a revision range which didn't touch the file to blame. So
the callback was never hit.

I suggest returning an error there, something like "nothing to blame for
the specified revision range".

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-07-02 18:21:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.