Re: svn commit: r31941 - branches/issue-2843-dev/subversion/libsvn_wc

>>> + invalid = is_this_dir ^ (entry->depth != svn_depth_exclude);
>>
>> I'm pretty sure as a style issue we don't use bitwise operations in
>> boolean operations here. If you could rewrite that in normal !, && and
>> || that would be clearer.
>The logic here is indeed XOR. What if I change this to the following?
> invalid = (is_this_dir ^ (entry->depth != svn_depth_exclude)) == 1;

just use != as the boolean equivalent

        invalid = is_this_dir != (entry->depth != svn_depth_exclude);

-- 
Lorenz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org