[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] pre 1.5 api bug, bad array allocation.

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 01 Jul 2008 11:21:21 -0400

Martin Hauner <martin.hauner_at_gmx.net> writes:
> here is a small patch fixing a bad array allocation in 1.5 in the pre
> 1.5 commit api. Since we are pushing pointers into the array, we should give
> it the pointer size and not the struct size. The old code inserts the pointer
> elements in a distance of 28 bytes.
>
> I also changed a wrong parameter for log_msg_func2, at least it looks wrong
> to me. I'm still running the log_msg_func code so i didn't step through that
> path.

Thanks for fixing these -- committed in r31944, and nominated for
backport to 1.5.1.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-07-01 17:22:19 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.