[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] hooks-scripts: fix svn2feed.py on Windows

From: Niels de Vos <niels.devos_at_wincor-nixdorf.com>
Date: Mon, 30 Jun 2008 12:14:39 +0200

Peter Samuelson wrote:
> [Peter Samuelson]
>> How annoying. By passing a list, you don't have to worry about
>> quoting your arguments, to account for spaces and such in filenames.
> I'm told you can get the same safety with the 'subprocess' module ...
> which is only provided on python2.4 (from December 2004) and up. Did
> we ever decide whether we could ditch python 2.2 and 2.3 users yet?

Here's a patch for review with popen.popen* replaced by the
subprocess-module. It should work on both UNIX and Windows. Only tested
on UNIX for now.

Note that this patch also changes the output of the feed to match the
format of viewvc more.

I could update the patch to only reflect the popen-subprocess change if


Received on 2008-06-30 20:24:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.