[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix issue #2809

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Mon, 30 Jun 2008 14:52:02 +0530

Hi Julian,

Julian Foad wrote:
>>From reading the patch and the rest of the log message, I see that this
> patch leave the regular output just how it was, and adds an "--xml"
> option for giving XML output when the user wants it, which is the
> solution suggested in the issue tracker. It would be good to say this in
> the log message summary paragraph so that the reader does not have to go
> and investigate.

Updated the log message.

> Is there a reason for this difference?

Actually, I missed it during my initial development of this patch. Thanks for
pointing it out.

> There's one warning when I build with this patch:
> subversion/svnlook/main.c:1548: warning: no previous prototype for
> 'print_xml_prop'

The updated patch must not give this warning.

I ve attached an updated patch with the above changes and log message changed.
Julian, Thanks for your review.

Senthil Kumaran S

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-06-30 11:23:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.