[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31713 - in branches/issue-2843-dev/subversion: include libsvn_wc svn

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Sun, 29 Jun 2008 21:37:24 -0400

"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
>> This isn't your code, but I see a lot of "if (*eb->target)" in this
>> file, which makes me think that when there is no target, eb->target is
>> "" rather than NULL. Which is fine, but we should document that in
>> struct edit_baton!
> It should have been ensured by svn_wc_adm_open_anchor(), I think. The document
> about anchor in notes/ directory has some words on it, if I recall correctly.

I've documented it now, see r31916.

>> The 'current_entry' here is just the parent's entry for the subdir,
>> right? And therefore the only reason we're using svn_depth_infinity is
>> so that that subdir entry won't write out an explicit depth, and the
>> subdir itself will know its own actual depth? (Just checking my own
>> understanding.)
> Yes. The depth field was only stored in this_dir entry. And I extend it
> that the subdir entry may have an 'exclude' depth value indicating that it is
> cropped out. However, the old depth values are still handled in the usual
> way.(in other words, restrictive values other 'exclude' is not allowed in
> subdir entries. May I explicitly check this in read_entry()?)

Yes, in fact I think that would be a good idea! :-)

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-30 03:38:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.