Re: [PATCH] hooks-scripts: fix svn2feed.py on Windows

[Niels de Vos]
> It seems that popen() does not allow a list as first parameter. The
> Python-docs explicitly note that on UNIX a sequence can be passed,
> Windows is not mentioned.

How annoying. By passing a list, you don't have to worry about quoting
your arguments, to account for spaces and such in filenames. Your
patch will not work, for example, if a repository path is under
C:\Documents and Settings, or if svnlook_cmd is under C:\Program Files.

I suggest doing something along the lines of

  cmd = '"%s" info -r%s "%s"' % svnlook_cmd, revision, self.repos_path

-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/