Re: [PATCH] Fix issue #2242.

Hi Daniel,

Daniel Shahaf wrote:
> Thanks for your patience with this patch. I'll look at it now.

This is really a good news! I am really happy :)

>> apr_pool_t *pool)
>> {
>> svn_string_t *str;
>> - str = apr_hash_get(creds, SVN_AUTH__AUTHFILE_PASSWORD_KEY,
>> + str = apr_hash_get(creds, SVN_AUTH__AUTHFILE_USERNAME_KEY,
>> APR_HASH_KEY_STRING);
>> - if (str && str->data)
>> + if (strcmp(str->data, username) == 0)
> ^
>
> Can STR be NULL here? I prefer
>
> str = apr_hash_get(creds, SVN_AUTH__AUTHFILE_USERNAME_KEY,
> APR_HASH_KEY_STRING);
> if (str && strcmp(str->data, username) == 0)

Yes a check for STR is nice here. I am +1 for this.

>> {
>> - *password = str->data;
>> - return TRUE;
>> + str = apr_hash_get(creds, SVN_AUTH__AUTHFILE_PASSWORD_KEY,
>> + APR_HASH_KEY_STRING);
>> + if (str && str->data)
>> + {
>> + *password = str->data;
>> + return TRUE;
>> + }
>> }
>> return FALSE;
>> }
>>
>
> Can you write a regression test?

With pleasure. I shall do it asap.

Once again thanks for your time in reviewing this patch.

-- 
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org