Re: [patch] Fix for JavaHL copy sources bug reported by Alexander Kitaev

Dear Daniel,

I'm sorry for delay with the answer. I've built subversion from trunk
and applied your patch. Unfortunately it doesn't work as expected:

peg revision specified in CopySource is used now, but passing "null" in
place of peg revision in deprecated copy method results in the same
error as before (working copy path required for that operation).

So, I assume, we should either left this method as it is (as it is
deprecated) or pass Revision.BASE or Revision.HEAD basing on the path kind.

Alexander Kitaev,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!

Daniel L. Rall wrote:
> oka reported this today on IRC. He mentioned that he'd have a chance
> to test it out over the weekend. We could use some improved test coverage
> here, not necessarily for the deprecated API in this patch, but for the
> various permutations of CopySource usage in general.
>
> oka, if this patch works out for you, please expand on the summary of my
> change log message, as it doesn't properly capture the use cases involved
> here. Assuming this works out, I'll propose it for backport to 1.5.1.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-25 23:14:50 CEST