[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn:charset

From: Dag-Erling Smørgrav <des_at_des.no>
Date: Tue, 24 Jun 2008 18:49:29 +0200

Branko Œibej <brane_at_xbc.nu> writes:
> Dag-Erling Smørgrav <des_at_des.no> writes:
> > The svn:charset property is widely used, and has been for years. There
> > are even clients (e.g. SmartSVN) that rely on it when diffing files or
> > revisions with different encodings.
> Do all the clients that use it expect it to conform to the same specs?
>
> Whoever intruded on the reserved svn: property name namespace should
> git off their behind and do the groundwork to make sure all uses are
> consistent, then post patches to this list.

All I'm asking for is official sanction for the use of the svn:charset
property to store the IANA character set name that corresponds to the
file's encoding, independently of its media type. This is how it's
being used today by several Open Source projects (a quick search
uncovers Adium, Mono, Tartarus, Growl and Maccode, not counting projects
I'm involved in) and by at least one third-party Subversion client
(SmartSVN, based on SVNKit).

One argument in favor of svn:charset, independently of the above, is
that unlike the current trick of appending "; charset=%s" to the MIME
type, it works with auto-props.

I've attached a patch relative to trunk that:

 - adds svn:charset to svn_props.h;
 - adds it to the help text for propset;
 - updates the French and Norwegian translations accordingly (this
   doesn't seem to work, but they didn't work before I changed them, nor
   do they work in any other language I've tried);
 - modifies libsvn_wc to disallow svn:charset on non-file nodes, like it
   does for svn:mime-type;
 - modifies mod_dav_svn to take svn:charset into account when generating
   the Content-Encoding header.

DES

-- 
Dag-Erling Smørgrav - des_at_des.no


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

  • text/x-patch attachment: stored
Received on 2008-06-24 18:49:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.