Re: [PATCH 2/2] run ruby tests out-of-tree

Hi,

I'm sorry for my late response.
# RubyKaigi 2008 was convened at the last weekend.

2008/6/21 Peter Samuelson <peter_at_p12n.org>:

>> This is needed in order to run the ruby tests out-of-tree. But it
>> apparently breaks some assumptions in a few of the tests.

> This raises the question: why do the ruby tests put their temp files in
> the _source_ directory, anyway? Why not just in the current directory?
> Here is my fix.
>
> [[[
> In the ruby testsuite, create temporary directories in the build tree,
> not in the source tree. This avoids failures caused by the fact that
> relative wc paths ("../../../../../subversion/bindings/swig/etc.") are
> partially stripped ("subversion/bindings/swig/etc.") when passed to
> svn_wc_notify_func2.
>
> [In subversion/bindings/swig/ruby/test]
>
> * util.rb (setup_default_variables): Eliminate @base_dir; anchor all
> temporary files in the current dir rather than the source dir.
>
> * windows_util.rb (setup_svnserve): Move svnserve temp dir likewise.
>
> Patch by: Peter Samuelson <peter_at_p12n.org>
> ]]]

Could you commit your patches?

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org