[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31820 - trunk/subversion/libsvn_fs_base

From: Mark Phippard <markphip_at_gmail.com>
Date: Mon, 23 Jun 2008 13:33:33 -0700

On Fri, Jun 20, 2008 at 1:43 AM, Branko ╚ibej <brane_at_xbc.nu> wrote:
> C. Michael Pilato wrote:
>>
>> Karl (and others with BDB backend knowledge): this fix seems too easy to
>> be true. Can you sanity check it, please?
>
> I can't find anything wrong with this. Seems logical and nice and whythe***
> didn't I notice this booboo years ago. :)
>
> You may want to make this comment sound a bit less perplexing to the casual
> reader:
>
> /* KEY will be the entry name, VAL the dirent (about
> which we really don't care) */
>
> since we do in fact care about VAL now.
>
> Good catch!

Brane,

Can you give this a +1 for backport to 1.5.1? It needs a 3rd
signature and it seems like you have reviewed it.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2008-06-23 22:33:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.