[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #3189 Make CC (Carbon Copy) possible with commit-email.pl

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Thu, 19 Jun 2008 09:18:53 +0300 (Jerusalem Daylight Time)

Dick Marinus wrote on Wed, 18 Jun 2008 at 10:13 +0200:
> [[[
> Fix issue #3189: Make CC (Carbon Copy) possible with commit-email.pl
>
> * contrib/hook-scripts/commit-email.pl.in
> Add -c parameter which can be repeated to specify multiple CC
> addresses
> ]]]
>

It's not a review, but please notice r31755:

    Author: blair
    Date: Mon Jun 16 07:47:22 2008
    New Revision: 31755

    Log:
    Deprecate commit-email.pl and recommend mailer.py. See

    http://svn.haxx.se/dev/archive-2008-06/0479.shtml

    * contrib/hook-scripts/commit-email.pl.in:
      Renamed from tools/hook-scripts/commit-email.pl.in.
      Add a comment at the top indicating this script is deprecated.

    --- trunk/tools/hook-scripts/commit-email.pl.in Sun Jun 15 17:44:40 2008 (r31754, copy source)
    +++ trunk/contrib/hook-scripts/commit-email.pl.in Mon Jun 16 07:47:22 2008 (r31755)
    @@ -1,6 +1,14 @@
     #!/usr/bin/env perl
     
     # ====================================================================
    +# This script is deprecated. The Subversion developers recommend
    +# using mailer.py for post-commit and post-revprop change
    +# notifications. If you wish to improve or add features to a
    +# post-commit notification script, please do that work on mailer.py.
    +# See http://svn.collab.net/repos/svn/trunk/tools/hook-scripts/mailer .
    +# ====================================================================
    +
    +# ====================================================================
     # commit-email.pl: send a notification email describing either a
     # commit or a revprop-change action on a Subversion repository.
     #

So, thanks for your patch, but it is unlikely to get reviewed as most
developers agreed that commit-email.pl should be deprecated.

You're welcome, however, to port the patch to mailer.py (if it doesn't
already have this feature) and resubmit it.

Thanks,

Daniel

> Hi,
>
> I've created a patch for commit-email.pl (issue 3189). Please review.
>
> TIA
> Dick
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-19 08:19:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.