Re: [PATCH] Replacement for "assert" in the libraries

On Wed, 2008-06-18 at 17:32 +0200, Branko Èibej wrote:
> Julian Foad wrote:
>
> > +svn_error_t *
> > +svn_error_raise_on_malfunc(const char *file, int line, const char
> > *expr);
> > +
> > +/** Handle an internal error by printing a message to stderr and
> > aborting.
> > + *
> > + * This function implements @c svn_error_assertion_func_t.
> > + *
> > + * @since New in 1.6.
> > + */
>
> Surely you mean it implements svn_error_malfunc_cb_t.

Oh yes... thanks. Corrected in my local copy of the patch.

> "Malfunction" sounds so all stiff-upper-lip ... SVN_ERR_FREAKOUT or
> SVN_ERR_PANIC or SVN_ERR_HELP_HELP_HORRIBLE_HEFFALUMP would be so very
> much closer to the spirit of things here. :)

Heh.

> Apart from that, +1.

Thanks.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-18 17:52:19 CEST