[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: multiple password prompts

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 18 Jun 2008 12:54:34 +0200

On Wed, Jun 18, 2008 at 12:09:26PM +0530, Senthil Kumaran S wrote:
> Hi Stefan,
>
> Stefan Sperling wrote:
>> If you hard code *cached_answer to TRUE, you are overriding whatever
>> answer the user gave you. After all, the user may have said 'no',
>> in which case may_save_password is FALSE.
>>
>> The else condition at line number 297 you are referring to
>> is not triggered based on whether *cached_answer is TRUE
>> or FALSE. It's based on whether cached_answer is NULL or not.
>> It is NULL if we cannot find an answer in the cache. The value
>> of the answer (TRUE or FALSE) does not matter.
>
> I missed the '&' before may_save_password in the following code:
>
> <snip>
> SVN_ERR((*b->plaintext_prompt_func)(&may_save_password,
> realmstring,
> b->prompt_baton,
> pool));
>
> </snip>
>
> hence, I came to this conclusion. Sorry for the noise :)

No problem.

>> Do you agree or have I misunderstood you?
>
> Yes I perfectly agree with you. Unfortunately I am unable to reproduce
> this in my box today! Is googlecode.com the only way?

I don't know yet. I'll have to find some time to create an
account with googlecode and some code to open source :)

Stefan

  • application/pgp-signature attachment: stored
Received on 2008-06-18 12:54:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.