"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
>> Oh -- please do that on trunk (+1 from me), and just have it come over
>> to the branch the next time you merge.
>
> Err.. My fault. I've done this on my branch after I checked all your reviews,
> along with your other suggestions. So, to fix this problem, should I merge it
> to trunk or submit a patch? Or even revert that commit and redo it in trunk?
Nah, it's okay, just leave it on the branch. I think the slight extra
cleanliness of redoing it would not be worth the noise. Just try to
remember for the future that changes that aren't specific to the branch
can enter on trunk first (and usually someone will be quick to approve,
when they're like this one).
>> > In fact, I can also simply call svn_wc_remove_from_revision_control()
>> > for excluded subdirectory (even though my code may be a bit faster?)
>> > -- the document of svn_wc_remove_from_revision_control() seems a bit
>> > misleading. If I understand correctly, it can handle any target rather
>> > than just 'file and this_dir'.
>>
>> The documentation claims it can only do file and this_dir, but I'm not
>> sure why it has that requirement...
>
> I double checked the implementation and found the document correct. I was
> confused by the check that setup is_file flag when the target name is not
> SVN_WC_ENTRY_THIS_DIR. In fact, if you pass the subdir entry to that function,
> that entry itself will be removed, leaving the entire subdirectory intact.
Yep -- that's what I found when I looked in there too. I'm still not
sure why we arranged things this way, that's all :-).
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-18 05:03:00 CEST