On Sun, Jun 15, 2008 at 02:53:42PM +0800, Rui, Guo wrote:
> On Sat, Jun 14, 2008 at 08:58:08PM -0400, Karl Fogel wrote:
> > > --- branches/issue-2843-dev/subversion/libsvn_wc/adm_crawler.c (r31723)
> > > +++ branches/issue-2843-dev/subversion/libsvn_wc/adm_crawler.c (r31724)
> > > @@ -278,6 +278,19 @@ report_revisions_and_depths(svn_wc_adm_a
> > > continue;
> > > }
> > >
> > > + /* Report the excluded path, no matter whether report_everything. */
> > > + if (current_entry->depth == svn_depth_exclude)
> > > + {
> > > + SVN_ERR(reporter->set_path(report_baton,
> > > + this_path,
> > > + SVN_INVALID_REVNUM,
> > > + svn_depth_exclude,
> > > + FALSE,
> > > + NULL,
> > > + iterpool));
> > > + continue;
> > > + }
> > > +
> >
> > I think it would be good for this comment to explain in more detail why
> > we're reporting the excluded path always.
> Because the report_everything flag indicates that the server will treate the
> wc as empty and thus push full content of the files/subdirs. We just want to
> say no to this. Does it clear enough? I'll write it as the new comment.
I found a bug here during working on a new test case. The test is too
restrictive. We should bypass the svn_depth_exclude report when the
depth_is_sticky, so as to let go the server-side modifications.
After reading the crawler code, I was quite confused. There seems no easy way
to get the depth_is_sticky information. Why does the code work without knowing
the depth_is_sticky information? Server-side magic? It seems that the server
will always push edit to the degree required by 'requested_depth', while the
wc_dir is only used to determine whether full content or just delta is needed.
I did not read the server code very carefully. Correct me if I am wrong.
And I have one more question. The crawler code always use the same depth value
when calling report_revisions_and_depths(), even when the original value is
svn_depth_immediates. Some extra files will got reported in this situation. Am
I right?
Rui
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-16 18:23:59 CEST