[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31704 - in branches/issue-2843-dev/subversion: libsvn_client libsvn_wc

From: Rui, Guo <timmyguo_at_mail.ustc.edu.cn>
Date: Mon, 16 Jun 2008 13:40:21 +0800

On Sun, Jun 15, 2008 at 10:31:05AM -0400, Karl Fogel wrote:
> "Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
> >> We usually give the full path (from source tree root) of each file.
> >> It's not a big deal, just fix up the log message when you get a chance.
> >
> > Well, I just followed the hacking guide.
> Indeed -- I never noticed that recommendation! Sorry. It's fine either
> way, then. I have to admit I prefer having the full path, since we
> often have files with the same name (e.g., "lock.c") in different places
> in the tree, and if the full path is given I don't have to glance
> backwards to see which file we're dealing with.

No problem. I can do it either way.

> >>
> >> I realize it's not your code, but I find the reuse of "entries"
> >> confusing here, and wish there were a separate, block-local variable
> >> named "parent_entries" or something. Do you agree?
> >
> > Yep! Done, waiting for commit.
> Oh -- please do that on trunk (+1 from me), and just have it come over
> to the branch the next time you merge.

Err.. My fault. I've done this on my branch after I checked all your reviews,
along with your other suggestions. So, to fix this problem, should I merge it
to trunk or submit a patch? Or even revert that commit and redo it in trunk?

> > In fact, I can also simply call svn_wc_remove_from_revision_control()
> > for excluded subdirectory (even though my code may be a bit faster?)
> > -- the document of svn_wc_remove_from_revision_control() seems a bit
> > misleading. If I understand correctly, it can handle any target rather
> > than just 'file and this_dir'.
> The documentation claims it can only do file and this_dir, but I'm not
> sure why it has that requirement...

I double checked the implementation and found the document correct. I was
confused by the check that setup is_file flag when the target name is not
SVN_WC_ENTRY_THIS_DIR. In fact, if you pass the subdir entry to that function,
that entry itself will be removed, leaving the entire subdirectory intact.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-16 07:41:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.