Re: Help with issue #3217

Clint Lawrence <clint.lawrence_at_gmail.com> writes:
> There were two patches attached. libsvn_client-unversioned-log.diff has
> the relevant changes to the library code. The patch you've review
> includes
> only the changes to the svn client.

Ah. I got fooled by an unfortunate combination of circumstances:

   - You wrote a singular where you meant a plural in your original
     message ("I've attached two patch that are my first steps...")

   - One of the attachment's names ended with "-log", and people often
     attach their log message separately (we prefer it in the same
     attachment as the patch, but people still sometimes do it
     separately). So I assumed the first attachment was a log message,
     and then when I saw a log message in the second attachment, I
     thought it was just a duplicate.

   - There was no explicit statement of dependency between the two
     patches.

> I've updated both patches and the log messages to include your
> suggestions.

Thanks. I'll take a look.

When one patch depends on another, please always state that in a very
prominent way, like in the log message of the dependee. There are lots
of patches flying around on this list, so it's easy for reviewers to get
confused :-).

> The only way I can work out to get a suitable MIME type is to send as
> a txt
> file (I using Mail.app if anyone knows how to make it work...) Hope that
> is O.K. (make check passes with both patches applied to trunk)

Sure, .txt is fine (I don't know much about how to use Mail.app, sorry).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-15 18:12:27 CEST