[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: parsing of boolean config options

From: Branko Čibej <brane_at_xbc.nu>
Date: Sun, 15 Jun 2008 12:39:46 +0200

Karl Fogel wrote:
> Branko Čibej <brane_at_xbc.nu> writes:
>
>> Nope, config values should be consistent across all sections.
>>
>
> Sounds sane to me, on further thought. Shall we go with "yes"? How
> about the patch below (there's more past this patch, so keep reading):
>
> [[[
> * subversion/libsvn_subr/config_file.c
> (svn_config_ensure): Just recommend "yes", don't recommend "true" as
> an alternative.
> ]]]
>

The patch looks fine. "Yes" is stylistically more pleasing to the eye
than "true" here ... though it's your vermilion to my crimson.

But you really should read up on how we write log messages. :)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-15 12:40:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.