Jens Peters <jpeters7677_at_gmx.de> writes:
> Thank you for your reply. Attached to this mail is a better log
> message since I forgot the first part of it in my initial message :(
>
> [[[
> Fix a compile error when building javahl with nls support for Windows x64.
>
> * subversion/bindings/javahl/native/JNIUtil.cpp
> (JNIUtil::JNIGlobalInit)
> Change the type of 'inwords' and 'outbytes' to apr_size_t.
>
> Patch by: jpeters7677_at_gmx.de
> ]]]
Committed in r31737. Even though I don't even build JavaHL -- and if
this change turns out to be a mistake, I'll never be allowed to touch
that code again :-). But it looked pretty obviously correct.
I still can't quite figure out what apr_size_t is for (as opposed to
size_t), but the former is typedef'd to the latter, so I guess it
doesn't matter.
Hey, that rhymes.
-Karl
> Index: subversion/bindings/javahl/native/JNIUtil.cpp
> ===================================================================
> --- subversion/bindings/javahl/native/JNIUtil.cpp (revision 31618)
> +++ subversion/bindings/javahl/native/JNIUtil.cpp (working copy)
> @@ -183,7 +183,8 @@
> const char *internal_path;
> apr_pool_t *pool;
> apr_status_t apr_err;
> - unsigned int inwords, outbytes, outlength;
> + apr_size_t inwords, outbytes;
> + unsigned int outlength;
>
> apr_pool_create(&pool, 0);
> /* get dll name - our locale info will be in '../share/locale' */
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-15 03:48:26 CEST