[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Help with issue #3217

From: Clint Lawrence <clint.lawrence_at_gmail.com>
Date: Sat, 14 Jun 2008 20:02:23 +0100

I'd like to have a go at issue 3217, "svn commit should show unknown
files
in editor". I'm slowly trying to find my way around the source and
work out
how to approach it. I've attached two patch that are my first steps,
but I'd
appreciate some feed back to check I'm headed in the right direction
before
going too much further.

To start I've modified the log_msg_func callback to accept a new
argument
that will be an array of paths representing unversioned items. I've
added
the necessary logic in libsvn_client and updated the command line
client's
svn_cl__get_log_message so it accepts the list of unversioned items and
prints them in the log message.

If all that looks O.K. then my next step would be to extend the
harvest_committables function so it can find any unversioned files. Then
once that works, add the necessary logic into the library to filter
out all
the items that have been set to be ignored. The part I can't work out
at the
moment is *how* to find the unversioned items. When first looking
through
this I thought it should be easy to borrow that logic from the status
command
(including filtering ignores) but on closer inspection it looks like
status
and commit work quite differently. Hints on where to look would be
appreciated.

Cheers,
Clint

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-06-14 21:03:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.