[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31719 - in trunk/subversion/bindings/javahl: src/org/tigris/subversion/javahl tests/org/tigris/subversion/javahl

From: Mark Phippard <markphip_at_gmail.com>
Date: Thu, 12 Jun 2008 20:22:12 -0400

On Thu, Jun 12, 2008 at 8:19 PM, Blair Zajac <blair_at_orcaware.com> wrote:
> markphip_at_tigris.org wrote:
>>
>> Author: markphip
>> Date: Thu Jun 12 17:06:34 2008
>> New Revision: 31719
>>
>> Log:
>> JavaHL: Fix potential ArrayIndexOutOfBoundsException in
>> singleStatus method. Happens when method is called on
>> a non-existent path within the working copy.
>
> I would just add to the javadoc that this method may return null if the path
> being status'ed doesn't exist. Otherwise, I'm going to vote +1 on this.

I can do that, but the method is deprecated and this actually just
restores the method to what it returned prior to 1.5. Basically the
new code that does callbacks creates a situation where we can return
an empty array instead of a null. We just did not check for it.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-13 02:22:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.