Re: [PATCH] Specify serf's library dependencies in serf.m4

On Tue, Jun 10, 2008 at 12:15:12AM -0500, Peter Samuelson wrote:
>
> [Stefan Sperling]
> > - AC_CHECK_LIB(serf-0, serf_context_create,[serf_found="yes"])
> > + AC_CHECK_LIB(serf-0, serf_context_create,[serf_found="yes"], ,
> > + -lz `$apr_config --link-ld --libs` `$apu_config --link-ld --libs`)
>
> Shouldn't that be: $SVN_APRUTIL_EXPORT_LIBS $SVN_APR_EXPORT_LIBS -lz ?

Yep, that works also and looks much cleaner. Thanks!

I'd still like to know whether this patch breaks anything for
other people compiling with serf.

[[[

* build/ac-macros/serf.m4: Pass serf's library dependencies to
   AC_CHECK_LIB macro.

]]]

Index: build/ac-macros/serf.m4
===================================================================
--- build/ac-macros/serf.m4 (revision 31672)
+++ build/ac-macros/serf.m4 (working copy)
@@ -22,7 +22,8 @@ AC_DEFUN(SVN_LIB_SERF,
       AC_CHECK_HEADERS(serf.h,[
         save_ldflags="$LDFLAGS"
         LDFLAGS="$LDFLAGS -L$serf_prefix/lib"
- AC_CHECK_LIB(serf-0, serf_context_create,[serf_found="yes"])
+ AC_CHECK_LIB(serf-0, serf_context_create,[serf_found="yes"], ,
+ $SVN_APRUTIL_EXPORT_LIBS $SVN_APR_EXPORT_LIBS -lz)
         LDFLAGS="$save_ldflags"])
       CPPFLAGS="$save_cppflags"
     fi