[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Help on enhancement #3096

From: Andrés G. Aragoneses <knocte_at_gmail.com>
Date: Mon, 09 Jun 2008 12:39:15 +0200

Thanks for your reply Stefan! See inline:

Stefan Sperling wrote:
> On Mon, Jun 09, 2008 at 12:03:43PM +0200, "Andrés G. Aragoneses" wrote:
>> Hello devs.
>> I just need help on
>> http://subversion.tigris.org/issues/show_bug.cgi?id=3096 for:
>> 1) Reviewing my first patch and, if approved, commit it.
>> 2) Answer my question regarding the approach I should follow for the
>> next patch.
> +1 on moving the Log section to the top. This has always bothered
> me a bit. It's annoying having to scroll tons of screens in mutt
> sometimes just to get to the log message.

Ok, someone with commit rights? :)

> But I do not agree with making the following the default behaviour:
> - The list of changes should be added, instead of inline,
> with an attachment, in order to be able to:
> a) Delete attachments in your mail client tool in order to reduce
> disk space usage.
> b) Extract the diff file as a patch that you can commit to other
> branches if you want to.
> As for a), commit lists are high volume by definition, you should
> know what you're getting yourself into when you subscribe :)

Well, that use case is the most usual but my need for this actually
arised because of a totally different one: I worked for a company whose
software was propietary, and thus its commit-list subscribers were just
the developers payed to work on it. Obviously, you couldn't opt out to
this list so having the diffs in attachments would help in case some
commits are quite larger because:
a) Either you could stablish rules in your mailbox not to download the
big attachments.
b) Or you just could remove them from your inbox (either you use IMAP or
POP, this is useful for saving disk storage capacity, and at least I
know one mail client that has this feature).

> I'm more inclined to accept b), but not for the reason you
> state, cause you really want to use "svn merge" for that!

Of course, but giving more options is always welcome I guess (not all
kinds of devs bother to learn the svn merge command line...).

> But if adding a command line flag that allows the script to send
> the changes as attachments is possible, I'd say that's fine.

+1 for making it configurable, but IMO the attachment format should be
the default.



To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-09 12:37:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.