[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Let depth-tests-23 pass on Windows for dav|svn and bdb

From: Jens Peters <jpeters7677_at_gmx.de>
Date: Sun, 08 Jun 2008 14:55:27 +0200

Senthil Kumaran S wrote:
> If this is specific for Windows, a check for os type (os.name) would be
> good, along with a comment explaining why we have this as dglasser has
> pointed out.

I did a rerun on a much faster system and there I didn't got that
failure, thus I assume this is just a result of my 6 year old laptop ;).
According to Kamesh's report (
http://svn.haxx.se/dev/archive-2008-06/0151.shtml) I guess also that
this is not a windows only problem, but just occurs more often on
windows. I have attached a new patch with some explanation.

Fix a depth-tests-23 failure (Access is denied) for the combination
[bdb] x [svn | dav].

* subversion/tests/cmdline/depth_tests.py
   Insert one second sleep to give slower systems the time to release
   the Berkeley DB shared memory files before recreating the repository.

Patch by: jpeters7677_at_gmx.de

Index: subversion/tests/cmdline/depth_tests.py
--- subversion/tests/cmdline/depth_tests.py (revision 31618)
+++ subversion/tests/cmdline/depth_tests.py (working copy)
@@ -20,6 +20,7 @@
 # General modules
 import os
+import time
 # Our testing module
 import svntest
@@ -1264,6 +1265,10 @@
   # Reset and do it again, this time from above the working copy.
+ # Sleep for one second because the server process on [bdb] X [svn | dav] tests
+ # needs some time to releases the bdb shared memory files. Otherwise it
+ # could result in an 'access denied' error, especially on slower systems.
+ time.sleep(1)
   wc, ign_a, ign_b, ign_c = set_up_depthy_working_copies(sbox, empty=True)
   expected_output = svntest.wc.State(wc, {
       'iota' : Item(status='A '),

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-08 15:00:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.