Daniel Shahaf wrote on Sun, 8 Jun 2008 at 09:49 +0300:
> David Glasser wrote on Sat, 7 Jun 2008 at 23:11 -0700:
> > Um, I really don't want to drag this process out any longer. But as
> > far as I can tell, without backporting these revisions, every single
> > program written against the svn_repos API before 1.5.x (ie, the API
> > which does not include svn_repos_set_repos_capabilities) which tries
> > to commit anything to a repository with a start-commit hook will
> > dereference NULL (ie, crash) every time.
> >
> > Please please please somebody convince me that I am wrong in that
> > conclusion above. Because if we actually claim to care about API
> > users, that's pretty serious.
> >
>
> The conclusion is correct.
>
...
> it is an uninitialised pointer being dereferenced.
>
Fortunately, the svn_repos_t object is allocated by apr_pcalloc, so it
really is NULL and not random uninitialised garbage.
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-08 13:07:25 CEST