[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31616 - trunk

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sun, 08 Jun 2008 09:10:15 +0200

Paul Burba wrote:
> On Fri, Jun 6, 2008 at 4:06 PM, Karl Fogel <kfogel_at_red-bean.com> wrote:
>> pburba_at_tigris.org writes:
>>> Follow-up to r31614, the fix for issue #1796. Fix windows build.
>>> * build.conf
>>> (libsvn_subr): Add private\svn_utf_private.h to msvc-export list.
>> Thanks, Paul. Was there anything I could have done to remember that,
>> aside from, er, remember it?
> Start developing on Windows? :-) Seriously, that's what the buildbots
> are for no? We've all broken other platform's builds (well I
> certainly have anyway). Took all of 5 minutes to fix, if that, so
> it's not a problem.

I had the same question when I saw your commit and came to the same
conclusion as Paul. Why adding a new 'rule' and making sure all
committers remember it, where a) this situation occurs only a few times
a year and b) the workaround takes only 10 minutes to execute.

We could make gen-make.py smart enough to include all files in
/include/private in the msvc export list, but for me it's not worth the


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-08 09:10:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.