[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] proper indentation in merge conflict menu

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 6 Jun 2008 16:37:39 +0200

On Fri, Jun 06, 2008 at 03:56:57PM +0200, Jens Seidel wrote:
> On Fri, Jun 06, 2008 at 03:06:42PM +0200, Stefan Sperling wrote:
> > Note that probably not all systems we support have wide chars, so on
> I think one such system is cygwin.
> > What about maintaining multiple full text menus? The code could use
> I do not like text duplication. I have to translate it consistently.

We're currently talking of about 5 or 6 full text prompts that will share
most of their text. Each being about 3 lines long. I think this is a
negligible amount of additional translation overhead, considering that
it buys us consistent indentation for all languages on any platform
we support. And it keeps the code's complexity at the same level as it
currently is.

> Also formating strings should be factored out, e.g. via a format string
> such as "%s (%c) %s" where the first %s is some kind of space, %c could
> be a shortcut and %s the menu text. So one would need to translate this
> format specification only once and with a minor single change all lines
> (and maybe even different menus) can be adjusted at once.

I'm OK with this. But it works only as long as we don't need
the exact same format string for something else which is
internationalised as well, right?

> > This is very unfortunate. Doesn't gettext provide some way to deal
> > with these kinds of problems? How do other projects handle this?
> No, it doesn't.


> Using some kind of format string could help. Some
> libraries such as Qt use layout classes such as QVBox and QHBox
> and align all childrens of these vertically or horizontally,
> respectively. Complex layout can now be created by nesting these:
> QVBox(QHBox(%s), QHBox(QVBox(%s))).

I know you're not suggesting to, but I guess pulling in QT as
a dependency to solve this issue is out of question :)


  • application/pgp-signature attachment: stored
Received on 2008-06-06 16:38:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.