[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: use NULL commit callback in svn_repos_get_commit_editor5?

From: David Glasser <glasser_at_davidglasser.net>
Date: Thu, 5 Jun 2008 07:10:00 -0700

On Wed, Jun 4, 2008 at 11:45 PM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> "David Glasser" <glasser_at_davidglasser.net> writes:
>> I dunno, but looking at the original code it looks like there's an
>> error leak if either svn_fs_revision_prop call fails. And the call to
>> svn_error_clear(err), as well as the final "return err;", seem wrong,
>> since err should be guaranteed to be SVN_NO_ERROR by that point. Am I
>> missing something?
> You mean the existing code, before the patch? Yes, it looks wonky to me
> too. Fixing that up would be a good idea, but I'm not going to attempt
> it at 3am... :-)

Yeah, I mean the existing code: I was checking your patch for an error
leak and went "guh?".


David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-05 16:10:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.