[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: log-report without path breaks compatibility

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 03 Jun 2008 11:11:15 -0400

Martin von Gagern wrote:
> Mark Phippard wrote:
>> This is the revision I am thinking of from the 1.5.x branch:
> That's iterating for assertions in ra_loader, while I'm talking about
> request construction for neon.
> P.S.: I should really try to remember replying to the list as well.

I'm not sure why your patch is necessary. In both Subversion 1.4.x and
1.5.x, the paths passed to svn_repos_get_logsX() from mod_dav_svn's parsing
of the log REPORT are non-NULL. If the parser happens to see a <S:path>
tag, it adds the path to the already-allocated array thereof; if it doesn't,
it doesn't.

Given my last past, in which I actually *looked* at the log code and
determined that, from the repository logic's perspective, NULL paths and
empty paths are the same thing, does your patch still matter?

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-06-03 17:11:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.