Karl Fogel <kfogel_at_red-bean.com> writes:
> Olav Vitters <olav_at_bkor.dhs.org> writes:
>> I'd really appreciate thing being committed, or even just looked at. Out
>> of the 5 patches I've mailed, only 1 patch seems to have gotten a
>> response. Two haven't even arrived (although I was subscribed). Attached
>> patch for instance did not get a response.
>
> Sorry about that. We moderate pretty carefully; I don't know why your
> posts wouldn't get through...
>
>> I'd really like to enhance mailer.py (fix TODOs), but please.. review
>> these patches.
>
> Did your original postings include log messages, as described in
> http://subversion.tigris.org/hacking.html#patches ? Having a log
> message dramatically increases the chances of a patch being reviewed.
>
> The version you included in this most recent post does not seem to have
> a log message. I tweaked the patch (so the code would not exceed the 80
> column limit), and wrote a log message. However, I am not sure the
> change is correct: for one thing, the string "_default_" does not appeal
> in the example conf file, although "[default]" does. But I'm not very
> familiar with mailer.py, so perhaps you can explain this.
Ah, I just read
http://thread.gmane.org/gmane.comp.version-control.subversion.devel/95393
...kindly referred to by Daniel Shahaf. (This shows how important it is
to give context! :-) ).
For this change to go in, the new "_default_" feature also needs to be
documented in the example config file. A feature that no one knows
about, or that no one knows how to use, might as well not exist.
Thanks,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-03 03:59:36 CEST