Re: [PATCH] Let depth-tests-23 pass on Windows for dav|svn and bdb

I'm not sure if this is the best way to fix it, but at the very least
there should be a comment explaining the cause for the sleep.

--dave

2008/6/1 Jens Peters <jpeters7677_at_gmx.de>:
> Hello there,
>
> As mentioned here earlier I see depth-tests failures on my system with the
> combination svn | dav and bdb. See
> http://svn.haxx.se/dev/archive-2008-05/0166.shtml for details. I finally
> found some time to dig into it and as a result the attached patch fixes the
> issue for me.
>
> I know that this is more an ugly workaround than a real fix. But is seems to
> work fine and at least all tests are green now (which feels actually pretty
> good, +1 to release from me :) ). Any chance that this patch or anything
> similar can be committed? Note thas this patch is made against 1.5-rc8. I
> would love to make patch against trunk, but first I would like to know if it
> will be accepted.
>
> Regards, Jens
>
> [[[
> Fix a depth-tests-23 failure (WindowsError: Access is denied) on Windows for
> the combination [svn | dav] and [bdb].
>
> * subversion/tests/cmdline/depth_tests.py
> Insert one second sleep to give Windows the time to release the Berkeley DB
> file handles before recreating the repository.
> ]]]
>
>
>
> Index: subversion/tests/cmdline/depth_tests.py
> ===================================================================
> --- subversion/tests/cmdline/depth_tests.py (revision 31532)
> +++ subversion/tests/cmdline/depth_tests.py (working copy)
> @@ -20,6 +20,7 @@
>
> # General modules
> import os
> +import time
>
> # Our testing module
> import svntest
> @@ -1264,6 +1265,7 @@
>
> # Reset and do it again, this time from above the working copy.
> svntest.main.safe_rmtree(wc)
> + time.sleep(1)
> wc, ign_a, ign_b, ign_c = set_up_depthy_working_copies(sbox, empty=True)
> expected_output = svntest.wc.State(wc, {
> 'iota' : Item(status='A '),
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org