[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31550 - trunk/subversion/libsvn_ra_serf

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Mon, 02 Jun 2008 07:34:21 +0200

Karl Fogel wrote:
> lgo_at_tigris.org writes:
>> --- trunk/subversion/libsvn_ra_serf/serf.c (r31549)
>> +++ trunk/subversion/libsvn_ra_serf/serf.c (r31550)
>> @@ -1163,6 +1163,15 @@ svn_ra_serf__get_repos_root(svn_ra_sessi
>> return SVN_NO_ERROR;
>> }
>> +/* TODO: to fetch the uuid from the repository, we need:
>> + 1. a path that exists in HEAD
>> + 2. a path that's readable
>> +
>> + get_uuid handles the case where a path doesn't exist in HEAD and also the
>> + case where the root of the repository is not readable.
>> + However, it does not handle the case where we're fetching path not existing
>> + in HEAD of a repository with unreadable root directory.
>> + */
>> static svn_error_t *
>> svn_ra_serf__get_uuid(svn_ra_session_t *ra_session,
>> const char **uuid,
> This doc string raises the question of whether a client *should* be able
> to get the UUID of a repository if the client cannot provide a readable
> path for that repository. I mean, why should the server confirm that a
> repository even *exists* at (or above) a given URL, if the root of that
> repository is not readable and the client does not know a readable path
> inside it?

The doc string is supposed to refer to the case where the user knows a
valid path in an older revision, by providing an url and a peg rev.
Seeing you misread it means I have to improve the doc string.

> If there is no other way to determine that a repository is there, giving
> the UUID is an information leak, because it confirms the existence of
> the repository. But if there are other ways to determine that a
> repository is there (such as by getting read errors), then the question
> is, are those other ways also information leaks, or do we just decide
> that this is okay to confirm?

Good question.
The get uuid call to the server will return 403 Forbidden on queries to
non-existant paths. That doesn't mean we don't spill the existence of a
repository in another way, but at least get_uuid doesn't seem to.

I do think we should try to avoid confirming the existence of a
repository if at all possible, but I have no idea how far of we are from
that principle.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-06-02 07:34:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.