[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Extend "Obvious fix" rule in HACKING

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 30 May 2008 12:33:43 -0400

Justin Erenkrantz wrote:
> On Fri, May 30, 2008 at 5:01 AM, Stefan Sperling <stsp_at_elego.de> wrote:
>> +<p>Whenever you are invoking the "obvious fix" rule, please say so in
>> +the log message of your commit. For example:</p>
>> +
>> +<pre>
>> + www/hacking.html: Obvious fix: Kill some typos.
>> +</pre>
>
> It's a bikeshed, but I'd do:
>
> ---
> Obvious fix.
>
> * www/hacking.html: Kill some typos.
> ---
>
> I'm not a fan of having the rule conflated with the change
> description. -- justin

Bikeshed indeed, but sound reasoning nonetheless. +1.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-05-30 18:33:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.