[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #2662, yet another authz wildcards support patch...

From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>
Date: Fri, 30 May 2008 15:27:04 +0200

2008-05-30 14:56:47 Gerald Macinenti napisaƂ(a):
> Daniel Shahaf wrote:
> > Gerald Macinenti wrote on Fri, 30 May 2008 at 10:33 +0200:
> >> this new version of the patch addresses the following issues some of you
> >> pointed me at:
> >> * superfluous use of "count" and "iteration_pool"
> >> * try find_option before find_section so that exactly matching sections
> >> have precedence over wildcard sections
> >> * added documentation and log message
> >> * GNU coding style
> >>
> >>
> >
> > Gerald, did you write and test the patch against trunk or against 1.4.6?
> > This time it applies cleanly, but in general patches should be written
> > (and tested) against trunk. Did you test the new functionality with trunk?
> against trunk, and yes I tested the new functionality in a real
> installation from trunk sources (apache + mod_authz_svn only, not svnserve).
>
> But the "make check" that was all good when I was working on the CentOS5
> 1.4.2 version skips all the authz tests in trunk (with or without the
> patch):
> SKIP: authz_tests.py 1: authz issue #2486 - open root
> SKIP: authz_tests.py 2: authz issue #2486 - open directory
> SKIP: authz_tests.py 3: broken authz files cause errors
> SKIP: authz_tests.py 4: test authz for read operations
> SKIP: authz_tests.py 5: test authz for write operations
> SKIP: authz_tests.py 6: test authz for checkout
> SKIP: authz_tests.py 7: test authz for log and tracing path changes
> SKIP: authz_tests.py 8: test authz for checkout and update
> SKIP: authz_tests.py 9: test authz for export with unreadable subfolder
> SKIP: authz_tests.py 10: test authz for aliases
> SKIP: authz_tests.py 11: test the authz validation rules
> SKIP: authz_tests.py 12: test authz for locking
> SKIP: authz_tests.py 13: authz issue #2712
> SKIP: authz_tests.py 14: switched to directory, no read access on parents
>
> why? I give the tests log in attachment.

NEVER SEND SUCH HUGE FILES IN UNCOMPRESSED FORM!!!

This attachment has ~3041 KiB (~2,97 MiB), but after compressing it with bzip2
it would have only ~95 KiB.

-- 
Arfrever Frehtes Taifersar Arahesis

Received on 2008-05-30 15:33:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.