[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: commits made directly to 1.5.x

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 30 May 2008 13:36:11 +0200

On Thu, May 29, 2008 at 09:18:35PM +0200, Jens Seidel wrote:
> The problem was that xgettext, a tool to extract messages from source
> code to put it into a .pot translation template file, failed to parse
> these strings containing macros. This resulted in no such messages
> in the translation PO files (and were that's why not translated) which I
> fixed by manually inserting these messages.
> Without macros xgettext works well and even after the next po-update.py
> call PO files no messages will be missing.

Including this kind of information in your log messages would
be a very, very nice thing to do. In the log, you only mention "xgettext
problem" and "xgettext limitation". That provides no information at all
to the reader. Not everyone knows what xgettext is, let alone what
its quirks are. Could you propedit the log messages for the revisions
where you fixed the problem?

And, by the way, what you wrote above is also a good example for
what you could have sent to the list in order to discuss the fix before
committing. I know I've already raised this issue and we talked it
through in another thread, but the above is a really good explanation
of *why* you made the change, so I'm pointing it out again here. The above
is exactly the kind of information others need to understand and evaluate
your changes.

> > > Let's just avoid this situation in the future.
>
> Right! Don't revert it! It was carefully proven by me and others!

OK.

I agree with Lieven, -rc8 is out of the bag, so we can just
leave them in now.

Stefan

  • application/pgp-signature attachment: stored
Received on 2008-05-30 13:33:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.