[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 1.5.x branch: python/cmdline

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 30 May 2008 01:36:33 +0300 (Jerusalem Daylight Time)

Julian Foad wrote on Thu, 29 May 2008 at 22:01 +0100:
> Alexander Sinyushkin wrote:
> > Sorry, I don't understand what I'm missing. It's not exactly a paste, I
> > added description to changes
> >

(I didn't say this before, but I think the description is fine. I think
we all agree on this.)

> > >> * subversion/tests/cmdline/svntest/main.py
> > >> (def copy_repos): close dump_in just after the first call to
> > open_pipe()
> > >> (def run): set SVN_CURRENT_TEST environment variable to the current
> > test
> > >> being run
> > >> (def run_tests): make svndumpfilter_binary point to jsvndumpfilter
> > binary if
> > >> --use-jsvn is specified
> >
> > And why can not that entire and detailed description of mine be a log
> > message?
>
> Everyone else,
>
> Please remember to be gentle on new committers.
>
>
> Alexander,
>
> Your log message is not bad, it's just that regular committers are
> accustomed to a fairly precise and consistent style of log message, and it
...
>
> > Daniel Shahaf wrote:
> >
> > > Alexander, I asked for a log message, not for a paste of your original
> > > email surrounded by triple square brackets.
>

Rereading, it does sound less "gentle" than it could have been. Sorry for
this, Alexander; I was brief because I assumed you knew how our log
messages normally look, so a quick reminder would be enough.

While here, I noticed that HACKING doesn't make it clear enough how the
introductory paragraphs should be written (which is the issue here) --
there is only one example. See r31532.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-30 00:36:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.