[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 1.5.x branch: python/cmdline

From: Blair Zajac <blair_at_orcaware.com>
Date: Thu, 29 May 2008 13:33:42 -0700

Alexander Sinyushkin wrote:
> Sorry, I don't understand what I'm missing. It's not exactly a paste, I
> added description to changes

In general, if there's that much information in a log message, it should be in
the file itself. Also, the "story" part of the log message can be trimmed to
keep to the technical facts.

For example, having the usage of SVN_CURRENT_TEST should be in the file that
sets it, so other developers looking at it can see why its set, instead of
having to parse through log messages to see why it was added.

I would rather see the technical details of what you wrote go into the patch and
the log message with a high level summary.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-29 22:34:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.