[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 1.5.x branch: python/cmdline

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Thu, 29 May 2008 22:51:46 +0300 (Jerusalem Daylight Time)

Alexander, I asked for a log message, not for a paste of your original
email surrounded by triple square brackets.

Alexander Sinyushkin wrote on Fri, 30 May 2008 at 02:29 +0700:
> Sorry, here it is
>
> [[[
> Add a number of SVNKit related fixes to main.py
>
> Recently SVNKit developers have started to use client/server approach for
> running Subversion python tests suite against SVNKit Subversion library. They
> use a server that accepts Subversion commands through the TCP/IP socket and a
> client which is a bash script - it reads parameters, stdin, certain
> environment variables and then sends everything to the server.
>
> To send data to the server netcat program is used or, alternatively, bash
> /dev/tcp/host/port device. In both case complete stdin have to be read before
> sending data to the server. However, main.py doesn't close stdin of the
> launched process before launching another process (in particular when running
> svnadmin dump repos1 | svnadmin load repos2 commands). As a result the tests
> were entering a deadlock. Suggested patch doesn't change anything in tests
> behavior with native Subversion - it just closes stdin of the launched process
> as soon as no more data is about to be sent to the process stdin.
>
> Another modification included into this patch is setting
> SVN_CURRENT_TEST environment variable before running certain test. This
> allows SVNKit testing daemon to track what test is currently running when the
> whole test suite is launched (i.e. "./copy.py" without specifying exact test
> number to run).
>
> Finally, svndumpfilter_binary should point to a jsvndumpfilter binary if
> --use-jsvn is specified.
>
> * subversion/tests/cmdline/svntest/main.py
> (def copy_repos): close dump_in just after the first call to open_pipe()
> (def run): set SVN_CURRENT_TEST environment variable to the current test
> being run
> (def run_tests): make svndumpfilter_binary point to jsvndumpfilter binary if
> --use-jsvn is specified
> ]]]
>
> ----
> Alexander Sinyushkin,
> TMate Software,
> http://svnkit.com/ - Java [Sub]Versioning Library!
>
> Daniel Shahaf wrote:
> > Alexander Sinyushkin wrote on Fri, 30 May 2008 at 01:48 +0700:
> > > Ok, I made a patch for the trunk version of main.py. It's attached to this
> > > letter.
> > >
> >
> > As I've said before, please provide a log message.
> >
> > http://subversion.tigris.org/hacking.html#patches
> >
> >
> >
> > > ----
> > > Alexander Sinyushkin,
> > > TMate Software,
> > > http://svnkit.com/ - Java [Sub]Versioning Library!
> > >
> > > Stefan Sperling wrote:
> > > > On Thu, May 29, 2008 at 05:20:31PM +0700, Alexander Sinyushkin wrote:
> > > > > Or maybe you can merge these changes back to trunk after you apply the
> > > patch to the branch?
> > > > Changes made to Subversion should, in general, enter our code
> > > > base through trunk. This ensures developer sanity.
> > > >
> > > > Stefan
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-29 21:52:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.