[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: commits made directly to 1.5.x

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Thu, 29 May 2008 22:29:21 +0300 (Jerusalem Daylight Time)

Jens Seidel wrote on Thu, 29 May 2008 at 21:18 +0200:
> On Thu, May 29, 2008 at 09:16:39PM +0300, Daniel Shahaf wrote:
> > Lieven Govaerts wrote on Thu, 29 May 2008 at 20:01 +0200:
> > > Stefan Sperling wrote:
> Great! If you would revert r31506 you would add a regression because of
> r31501.
>
> > > While I don't think r31503 and r31506 were urgent 1.5.x material, they
> > > don't do much harm either. They're included in RC8 now, so the cost of
> > > rolling them back (ie; RC9) will be bigger than the benefit.
> > >
> >
> > We can include them in 1.5.1, as they only change the 'svn --help'
> > output. No rc9.
>
> That's wrong again! These patches just manually expand macros in help
> outputs (for commands resolve, mergeinfo and switch). There should be
> no change in the output!
>

That's what I said.

> The problem was that xgettext, a tool to extract messages from source
> code to put it into a .pot translation template file, failed to parse
> these strings containing macros. This resulted in no such messages
> in the translation PO files (and were that's why not translated) which I
> fixed by manually inserting these messages.
> Without macros xgettext works well and even after the next po-update.py
> call PO files no messages will be missing.
>
> > > Let's just avoid this situation in the future.
>
> Right! Don't revert it! It was carefully proven by me and others!
>
> Jens
>

Too many exclamation marks.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-29 21:29:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.