[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Jens, please try to get more peer review

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Thu, 29 May 2008 20:20:54 +0300 (Jerusalem Daylight Time)

Stefan Sperling wrote on Thu, 29 May 2008 at 17:49 +0200:
> On Thu, May 29, 2008 at 04:25:00PM +0200, Jens Seidel wrote:
> > Most of the time because the 'obvious fix'. If there was any doubt
> > I also wrote to this list. I also just forgot adding this flag at
> > least once.
>
> OK. Maybe we should require obvious fixes to be designated as such?
> Such as: "Obvious fix: Remove trailing whitespace"
>
> This would make it more obvious that the obvious fix rule was applied.
> Should we update HACKING accordingly?
>

Maybe "Approved by: obvious fix".

http://ff00ff.bikeshed.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-29 19:21:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.