[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31291 - trunk/subversion/bindings/javahl/native

From: Philip Martin <philip_at_codematters.co.uk>
Date: Thu, 29 May 2008 16:23:03 +0100

Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com> writes:

> 2008-05-29 15:42:25 Mark Phippard napisaƂ(a):
>> On Thu, May 29, 2008 at 9:34 AM, Philip Martin <philip_at_codematters.co.uk> wrote:
>> >
>> > The code still drops the error. Why is this code different from the
>> > RA loader code? Why don't you simply return the error?
>>
>> Is it because we expect the error to happen and we want to just know
>> there was an error and fallback to the other mechanisms? For example
>> if SVN is built with gnome-keyring and you are using the command line
>> in a terminal where those libraries are not available?
>
> Rather when Subversion is built with support for GNOME Keyring, but
> GNOME Keyring isn't installed.

That doesn't explain the current code. After svn_dso_load has
returned SVN_NO_ERROR you check dso to see if the library loaded;
that's the normal path and the library may or may not get loaded. The
exceptional path is that svn_dso_load returns an error, that's not
normal and the error should not be thrown away.

I don't understand why the current code doesn't do the same as the RA
code? Why is the keyring code different? Have you had problems if
the code is the same as the RA code? If it does need to be different
then something, svn_dso_load perhaps, needs better documentation.

One final point, why is code duplicated in libsvn_subr and javahl?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-29 17:23:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.