Re: svn commit: r31291 - trunk/subversion/bindings/javahl/native

Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com> writes:

> 2008-05-19 20:24:13 Philip Martin napisał(a):
>> arfrever_at_tigris.org writes:
>>
>> > + svn_error_clear(svn_dso_load(&dso, libname));
>> > + if (dso)
>> > + {
>> > + if (! apr_dso_sym(&provider_symbol, dso, funcname))
>> > + {
>> > + svn_auth_simple_provider_func_t func;
>> > + func = (svn_auth_simple_provider_func_t) provider_symbol;
>> > + func(provider, pool);
>> > + ret = TRUE;
>> > + }
>> > + }
>> > + return ret;
>> > +}
>> > +#endif
>>
>> I've seen this code before...
>>
>> Why is it acceptable to ignore errors from svn_dso_load?
>>
>> Why is it acceptable to use the dso variable if svn_dso_load returns
>> an error?
>
> Fixed in r31367.

The code still drops the error. Why is this code different from the
RA loader code? Why don't you simply return the error?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-29 15:34:49 CEST